Skip to content

Fix accessibility issues #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LadyBluenotes merged 3 commits into from
Feb 3, 2026
Merged

Fix accessibility issues #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ed9297
Fix accessibility issues
amirhhashemi Feb 3, 2026
30e1064
Merge branch 'main' into fix-a11y
kodiakhq[bot] Feb 3, 2026
a4eaf72
Merge branch 'main' into fix-a11y
kodiakhq[bot] Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/ui/callout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { Alert } from "@kobalte/core";
import { Icon } from "solid-heroicons";
import { mergeProps, type JSX, Show, untrack } from "solid-js";
import {
Expand Down Expand Up @@ -91,7 +90,7 @@ export function Callout(props: CalloutProps) {
const IconComponent = icons[iconType];

return (
<Alert.Root
<div
class={`my-6 flex w-full rounded-3xl border p-4 ${
styles[mergedProps.type].container
}`}
Expand All @@ -112,6 +111,6 @@ export function Callout(props: CalloutProps) {
{mergedProps.children}
</div>
</div>
</Alert.Root>
</div>
);
}
3 changes: 2 additions & 1 deletion src/ui/eraser-link/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,15 @@ const EraserLink = (
class="relative inline-block"
target="_blank"
rel="noopener noreferrer"
aria-label="View diagram on Eraser.io"
>
<img
src={
elementParams
? `${workspaceUrl}/preview?${elementParams}&type=embed`
: `${workspaceUrl}/preview`
}
alt={""}
alt=""
onLoad={() => setIsLoaded(true)}
/>
{isLoaded() ? (
Expand Down
5 changes: 4 additions & 1 deletion src/ui/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,10 @@ export const Layout: ParentComponent<{ isError?: boolean }> = (props) => {
</Suspense>
</div>
</Show>
<main class="prose prose-slate w-full flex-auto px-4 pt-2 dark:prose-invert md:max-w-2xl md:pb-16 lg:max-w-none dark:text-slate-300">
<main
class="prose prose-slate w-full flex-auto px-4 pt-2 dark:prose-invert md:max-w-2xl md:pb-16 lg:max-w-none dark:text-slate-300"
aria-live="polite"
>
<Show
when={!useCurrentRouteMetaData().isProjectRoot}
keyed
Expand Down
5 changes: 4 additions & 1 deletion src/ui/layout/mobile-navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ export const [isOpen, setIsOpen] = createSignal(false);
export const MobileNavigation = (props: NavProps) => {
return (
<Dialog.Root open={isOpen()} onOpenChange={setIsOpen}>
<Dialog.Trigger>
<Dialog.Trigger
aria-label="Open navigation menu"
title="Open navigation menu"
>
<Icon path={bars_3} class="prose h-6 dark:prose-invert" />
</Dialog.Trigger>
<Dialog.Portal>
Expand Down