From f5c1b8c45d5b2bd70d38aa6b32ebb033980a9bdf Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Sat, 17 May 2025 11:35:55 -0700 Subject: [PATCH 1/3] use `.` over `::` for consistency --- lib/json/common.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/json/common.rb b/lib/json/common.rb index 320df2a94..d7f0eb885 100644 --- a/lib/json/common.rb +++ b/lib/json/common.rb @@ -1072,7 +1072,7 @@ def j(*objs) end objs.each do |obj| - puts JSON::generate(obj, :allow_nan => true, :max_nesting => false) + puts JSON.generate(obj, :allow_nan => true, :max_nesting => false) end nil end @@ -1087,7 +1087,7 @@ def jj(*objs) end objs.each do |obj| - puts JSON::pretty_generate(obj, :allow_nan => true, :max_nesting => false) + puts JSON.pretty_generate(obj, :allow_nan => true, :max_nesting => false) end nil end From c060943d042ac7a1f68e4b6c691a12646a467acb Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Sat, 17 May 2025 11:37:39 -0700 Subject: [PATCH 2/3] remove redundant `self.` --- lib/json/common.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/json/common.rb b/lib/json/common.rb index d7f0eb885..6393a6df5 100644 --- a/lib/json/common.rb +++ b/lib/json/common.rb @@ -172,7 +172,7 @@ def generator=(generator) # :nodoc: end end self.state = generator::State - const_set :State, self.state + const_set :State, state ensure $VERBOSE = old end From 7c03ffc3e0a388ecf390f859221a047e2a21da46 Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Sat, 17 May 2025 21:02:04 +0200 Subject: [PATCH 3/3] Remove some unnecessary top level constant lookups --- lib/json/ext.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/json/ext.rb b/lib/json/ext.rb index 1db5ea122..5bacc5e37 100644 --- a/lib/json/ext.rb +++ b/lib/json/ext.rb @@ -34,12 +34,12 @@ def parse if RUBY_ENGINE == 'truffleruby' require 'json/truffle_ruby/generator' - JSON.generator = ::JSON::TruffleRuby::Generator + JSON.generator = JSON::TruffleRuby::Generator else require 'json/ext/generator' JSON.generator = Generator end end - JSON_LOADED = true unless defined?(::JSON::JSON_LOADED) + JSON_LOADED = true unless defined?(JSON::JSON_LOADED) end