From b9e4cad23d73aef128caefd27efd82774656bbe7 Mon Sep 17 00:00:00 2001 From: Michael Warres Date: Sat, 12 Jul 2025 16:27:54 +0000 Subject: [PATCH 1/3] chore: workflow runner fixes - Update format workflows to use ubuntu-22.04 - Enable manual triggering of workflows Fixes #435 Signed-off-by: Michael Warres --- .github/workflows/format.yml | 10 ++++++---- .github/workflows/test.yml | 2 ++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml index de71b24cc..1004f123f 100644 --- a/.github/workflows/format.yml +++ b/.github/workflows/format.yml @@ -31,6 +31,8 @@ on: schedule: - cron: '0 0 * * *' + workflow_dispatch: + concurrency: group: ${{ github.head_ref || github.run_id }}-${{ github.workflow }} @@ -41,7 +43,7 @@ jobs: addlicense: name: verify licenses - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v2 @@ -61,7 +63,7 @@ jobs: buildifier: name: check format with buildifier - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v2 @@ -99,7 +101,7 @@ jobs: clang_format: name: check format with clang-format - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v2 @@ -115,7 +117,7 @@ jobs: clang_tidy: name: check format with clang-tidy - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v2 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 811c6a369..9fad80a4f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -31,6 +31,8 @@ on: schedule: - cron: '0 0 * * *' + workflow_dispatch: + concurrency: group: ${{ github.head_ref || github.run_id }}-${{ github.workflow }} From 2b7403de6b2d71d8a26a4d0a49b3fea6c5b3d5e3 Mon Sep 17 00:00:00 2001 From: Michael Warres Date: Sat, 12 Jul 2025 16:37:29 +0000 Subject: [PATCH 2/3] update windows-2019 to windows-2022 The windows-2019 runner image has been retired. Signed-off-by: Michael Warres --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9fad80a4f..5a6dd8f49 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -129,7 +129,7 @@ jobs: flags: --config=clang-tsan - name: 'NullVM on Windows/x86_64' engine: 'null' - os: windows-2019 + os: windows-2022 arch: x86_64 action: test targets: -//test/fuzz/... From 895463a22dbec600a285838e15e75b542287acf5 Mon Sep 17 00:00:00 2001 From: Michael Warres Date: Sat, 12 Jul 2025 16:50:10 +0000 Subject: [PATCH 3/3] add missing include This appears to be tripping up Windows builds: ``` ERROR: D:/a/proxy-wasm-cpp-host/proxy-wasm-cpp-host/BUILD:64:11: Compiling src/signature_util.cc failed: (Exit 2): cl.exe failed: error executing command (from target //:base_lib) C:\users\runneradmin\_bazel_runneradmin\dwxiuyix\execroot\proxy_wasm_cpp_host\include/proxy-wasm/signature_util.h(30): error C2039: 'string': is not a member of 'std' cd /d C:/users/runneradmin/_bazel_runneradmin/dwxiuyix/execroot/proxy_wasm_cpp_host ``` Signed-off-by: Michael Warres --- include/proxy-wasm/signature_util.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/proxy-wasm/signature_util.h b/include/proxy-wasm/signature_util.h index 68579dcd1..a5c9c39df 100644 --- a/include/proxy-wasm/signature_util.h +++ b/include/proxy-wasm/signature_util.h @@ -14,6 +14,7 @@ #pragma once +#include #include namespace proxy_wasm {