Add OroCalendarBundle after a regular installation doesn't work

[RocKordier]

Hey,
as described in OSD-1745 its not possible to add the CalendarBundle after a regular OroPlatform installation.
I've added a small PostUpMigration which should do all the work which is also done in the EntityListener.
RocKordier/OroCalendarBundle@0e32b1d
That points me to the a small question. I think we don't need duplicate code here. So, why the UnitOfWork is involved here and had to computeChangeSet with the class metadata?
I think the code should go into the CalendarManager or so to create a full default calendar for a user if he hasn't one.

What you guys are thinking?
Thx, Eric

[d-beekeeper]

Hi RocKordier

We need to use $uow->computeChangeSet() because, in EntityListener, we do this inside Doctrine's onFlush event.
And, because of Doctrine's restrictions, calling $em->persist($calendar) at the newly created entity inside onFlush event isnt enough.
See http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/events.html#onflush

Of course, you dont need to do this inside your migration.

[RocKordier]

@d-beekeeper thx fuer the feedback,
Ok, should i leave it as it is and submit the pull request later (some tests are missing), or should I change it that both use the same way to create default calendars?

Eric

[dewos]

@mbessolov

Also, OroCalendarBundleInstaller::addCommentToCalendarEvent throws on updates.

Oro\Bundle\CalendarBundle\Migrations\Schema\OroCalendarBundleInstaller

In Inflector.php line 265:

Type error: Argument 1 passed to Doctrine\Common\Inflector\Inflector::tableize() must be of the type string, null given, called in \vendor\oro\platform\src\Oro\Bundle\EntityExtendBundle\Tools\ExtendHelper.php on lin
e 80