packages/ui-components/package.json

-Original file line number
+Diff line change
@@ -1,6 +1,6 @@
     {
       "name": "@node-core/ui-components",
-      "version": "1.5.8",
+      "version": "1.5.9",
       "type": "module",
       "exports": {
         "./*": [
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,8 @@ @@
         @apply [grid-area:sidebar]
           lg:sticky
           lg:top-0
-          lg:h-[100vh]
+          lg:max-h-screen
+          lg:self-stretch
           lg:overflow-y-auto;
       }
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,6 +4,7 @@ @@
       @apply flex
         w-full
         flex-col
+        items-start
         gap-8
         border-r-0
         border-neutral-200
@@ Expand All / @@ -20,6 +21,10 @@ @@
       .navigation {
         @apply hidden
           sm:flex;
+        &:last-child {
+          @apply pb-12;
+        }
       }
       .mobileSelect {
@@ Expand Down @@

fix(ui): Sidebar scroll not showing last element #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

malav2110 wants to merge 8 commits into nodejs:main from malav2110:fix-sidebar-scroll-last-item

+8 −2

-Original file line number
+Diff line change
@@ -1,6 +1,6 @@
     {
       "name": "@node-core/ui-components",
-      "version": "1.5.8",
+      "version": "1.5.9",
       "type": "module",
       "exports": {
         "./*": [
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,8 @@ @@
         @apply [grid-area:sidebar]
           lg:sticky
           lg:top-0
-          lg:h-[100vh]
+          lg:max-h-screen
+          lg:self-stretch
           lg:overflow-y-auto;
       }
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,6 +4,7 @@ @@
       @apply flex
         w-full
         flex-col
+        items-start
         gap-8
         border-r-0
         border-neutral-200
@@ Expand All / @@ -20,6 +21,10 @@ @@
       .navigation {
         @apply hidden
           sm:flex;
+        &:last-child {
+          @apply pb-12;
+        }
       }
       .mobileSelect {
@@ Expand Down @@

Provide feedback