Skip to content

fix(git-node): do not enforce minimum wait time for release proposals #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(git-node): do not enforce minimum wait time for release proposals #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d69002
fix(git-node): do not enforce minimum wait time for release proposals
aduh95 Feb 3, 2026
051915f
fixup! fix(git-node): do not enforce minimum wait time for release pr…
aduh95 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/pr_checker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,20 +128,26 @@ export default class PRChecker {
}
}

checkReviewsAndWait(now, checkComments) {
checkReviewsAndWait(now, checkComments, isReleaseProposal) {
const {
pr, cli, reviewers
} = this;
const { requestedChanges, approved } = reviewers;

const dateStr = new Date(pr.createdAt).toUTCString();
cli.info(`This PR was created on ${dateStr}`);
this.displayReviews(checkComments);

if (isReleaseProposal) {
cli.info('This PR is a release proposal');
return approved.length !== 0;
}

const labels = pr.labels.nodes.map((l) => l.name);

let isFastTracked = labels.includes('fast-track');
const isCodeAndLearn = labels.includes('code-and-learn');
const isSemverMajor = labels.includes('semver-major');

const dateStr = new Date(pr.createdAt).toUTCString();
cli.info(`This PR was created on ${dateStr}`);
this.displayReviews(checkComments);
// NOTE: a semver-major PR with fast-track should have either one of
// these labels removed because that doesn't make sense
if (isFastTracked) {
Expand Down
2 changes: 1 addition & 1 deletion lib/promote_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ export default class ReleasePromotion extends Session {
const checker = new PRChecker(cli, data, { prid, owner, repo }, { maxCommits: 0 });
const jenkinsReady = checker.checkJenkinsCI();
const githubCIReady = checker.checkGitHubCI();
const isApproved = checker.checkReviewsAndWait(new Date(), false);
const isApproved = checker.checkReviewsAndWait(new Date(), false, true);

return {
githubCIReady,
Expand Down
Loading