Fix CI pipeline steps and move @microsoft/rush to nonbrowser-approved-packages.json

Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>

Author: Copilot

.github/workflows/ci.yml

@@ -80,11 +80,8 @@ jobs:
         working-directory: repo-a
 
       - name: Run package manager integration tests
-        run: |
-          node ${{ github.workspace }}/repo-a/apps/rush/lib/start-dev.js build --to rush-package-manager-integration-test
-          cd build-tests/rush-package-manager-integration-test
-          npm run test
-        working-directory: repo-a
+        run: npm run test
+        working-directory: repo-a/build-tests/rush-package-manager-integration-test
 
       - name: Ensure repo README is up-to-date
         run: node repo-scripts/repo-toolbox/lib/start.js readme --verify

common/config/azure-pipelines/templates/build.yaml

@@ -25,8 +25,6 @@ steps:
   - script: 'node common/scripts/install-run-rush.js retest --verbose --production ${{ parameters.BuildParameters }}'
     displayName: 'Rush retest (install-run-rush)'
 
-  - script: |
-      node apps/rush/lib/start-dev.js build --to rush-package-manager-integration-test
-      cd build-tests/rush-package-manager-integration-test
-      npm run test
+  - script: 'npm run test'
+    workingDirectory: 'build-tests/rush-package-manager-integration-test'
     displayName: 'Run package manager integration tests'

common/config/rush/browser-approved-packages.json

@@ -14,10 +14,6 @@
       "name": "@lifaon/path",
       "allowedCategories": [ "libraries" ]
     },
-    {
-      "name": "@microsoft/rush",
-      "allowedCategories": [ "tests" ]
-    },
     {
       "name": "@radix-ui/colors",
       "allowedCategories": [ "libraries" ]

common/config/rush/nonbrowser-approved-packages.json

@@ -62,6 +62,10 @@
       "name": "@microsoft/load-themed-styles",
       "allowedCategories": [ "libraries" ]
     },
+    {
+      "name": "@microsoft/rush",
+      "allowedCategories": [ "tests" ]
+    },
     {
       "name": "@microsoft/rush-lib",
       "allowedCategories": [ "libraries", "tests", "vscode-extensions" ]