Skip to content

Commit 30fc4f1

Browse files
Copiloticlanton
andcommitted
Fix linter warnings and update API file
Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>
1 parent 3b427fe commit 30fc4f1

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

common/reviews/api/rush-lib.api.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1176,6 +1176,7 @@ export class PnpmOptionsConfiguration extends PackageManagerOptionsConfiguration
11761176
readonly resolutionMode: PnpmResolutionMode | undefined;
11771177
readonly strictPeerDependencies: boolean;
11781178
readonly unsupportedPackageJsonSettings: unknown | undefined;
1179+
updateGlobalOnlyBuiltDependencies(onlyBuiltDependencies: string[] | undefined): void;
11791180
updateGlobalPatchedDependencies(patchedDependencies: Record<string, string> | undefined): void;
11801181
readonly useWorkspaces: boolean;
11811182
}

libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -609,24 +609,24 @@ export class WorkspaceInstallManager extends BaseInstallManager {
609609
tipIDsToBePrinted.add(tipId);
610610
}
611611
}
612-
612+
613613
// Replace `pnpm approve-builds` with `rush-pnpm approve-builds` when running
614614
// `rush install` or `rush update` to instruct users to use the correct command
615-
const modifiedChunk = chunk.replace(
615+
const modifiedChunk: string = chunk.replace(
616616
/pnpm approve-builds/g,
617617
`rush-pnpm --subspace ${subspace.subspaceName} approve-builds`
618618
);
619-
619+
620620
// Return modified chunk if it was changed, otherwise return void to keep original
621621
return modifiedChunk !== chunk ? modifiedChunk : undefined;
622622
}
623623
: (chunk: string): string | void => {
624624
// Even when no tips are registered, we still need to rewrite the approve-builds command
625-
const modifiedChunk = chunk.replace(
625+
const modifiedChunk: string = chunk.replace(
626626
/pnpm approve-builds/g,
627627
`rush-pnpm --subspace ${subspace.subspaceName} approve-builds`
628628
);
629-
629+
630630
// Return modified chunk if it was changed, otherwise return void to keep original
631631
return modifiedChunk !== chunk ? modifiedChunk : undefined;
632632
};

0 commit comments

Comments
 (0)