Release/v1.0 (MultimediaTechLab#225)

* [Fix] typo of quiet (from quite)

* 🐛 [Add] Gradient acc for stable single gpu

* 🐛 [Fix] for setting multigpu, enable pick cuda id

* 💚 [Fix] bug for pytest for inference

* 📝 [Update] Docs, remove broken badge

Author: henrytsui000

.github/workflows/deploy.yaml

@@ -61,7 +61,7 @@ jobs:
       run: |
         python yolo/lazy.py task=inference use_wandb=False
         python yolo/lazy.py task=inference use_wandb=False model=v7
-        python yolo/lazy.py task=inference use_wandb=False +quite=True
+        python yolo/lazy.py task=inference use_wandb=False +quiet=True
         python yolo/lazy.py task=inference use_wandb=False name=AnyNameYouWant
         python yolo/lazy.py task=inference use_wandb=False image_size=\[480,640]
         python yolo/lazy.py task=inference use_wandb=False task.nms.min_confidence=0.1

README.md

@@ -2,12 +2,10 @@
 
 [![Documentation Status](https://readthedocs.org/projects/yolo-docs/badge/?version=latest)](https://yolo-docs.readthedocs.io/en/latest/?badge=latest)
 ![GitHub License](https://img.shields.io/github/license/WongKinYiu/YOLO)
-![WIP](https://img.shields.io/badge/status-WIP-orange)
 
 [![Developer Mode Build & Test](https://github.com/WongKinYiu/YOLO/actions/workflows/develop.yaml/badge.svg)](https://github.com/WongKinYiu/YOLO/actions/workflows/develop.yaml)
 [![Deploy Mode Validation & Inference](https://github.com/WongKinYiu/YOLO/actions/workflows/deploy.yaml/badge.svg)](https://github.com/WongKinYiu/YOLO/actions/workflows/deploy.yaml)
 
-[![PWC](https://img.shields.io/endpoint.svg?url=https://paperswithcode.com/badge/yolov9-learning-what-you-want-to-learn-using/real-time-object-detection-on-coco)](https://paperswithcode.com/sota/real-time-object-detection-on-coco)
 
 [![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)]()
 [![Hugging Face Spaces](https://img.shields.io/badge/%F0%9F%A4%97%20Hugging%20Face-Spaces-green)](https://huggingface.co/spaces/henry000/YOLO)
@@ -87,7 +85,7 @@ python yolo/lazy.py task=inference \ # default is inference
                     task.nms.min_confidence=0.1 \ # nms config
                     task.fast_inference=onnx \ # onnx, trt, deploy
                     task.data.source=data/toy/images/train \ # file, dir, webcam
-                    +quite=True \ # Quite Output
+                    +quiet=True \ # Quiet Output
 yolo task.data.source={Any Source} # if pip installed
 yolo task=inference task.data.source={Any}
 ```

docs/HOWTO.md

@@ -17,7 +17,7 @@ python yolo/lazy.py task=validation dataset=toy name=validation
 # Inference
 python yolo/lazy.py task=inference
 python yolo/lazy.py task=inference device=cpu
-python yolo/lazy.py task=inference +quite=True
+python yolo/lazy.py task=inference +quiet=True
 python yolo/lazy.py task=inference name=AnyNameYouWant
 python yolo/lazy.py task=inference image_size=\[480,640]
 python yolo/lazy.py task=inference task.nms.min_confidence=0.1

tests/conftest.py

@@ -68,6 +68,7 @@ def model_v7(inference_v7_cfg: Config, device) -> YOLO:
 @pytest.fixture(scope="session")
 def solver(train_cfg: Config) -> Trainer:
     train_cfg.use_wandb = False
+    del train_cfg.task.data.equivalent_batch_size
     callbacks, loggers, save_path = setup(train_cfg)
     trainer = Trainer(
         accelerator="auto",

tests/test_utils/test_bounding_box_utils.py

@@ -118,7 +118,7 @@ def test_vec2box_autoanchor():
     with initialize(config_path="../../yolo/config", version_base=None):
         cfg: Config = compose(config_name="config", overrides=["model=v9-m"])
     device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
-    model = create_model(cfg.model, weight_path=None).to(device)
+    model = create_model(cfg.model, weight_path=None)
     vec2box = Vec2Box(model, cfg.model.anchor, cfg.image_size, device)
     assert vec2box.strides == [8, 16, 32]
 

yolo/config/config.py

@@ -60,6 +60,7 @@ class DataConfig:
     data_augment: Dict[str, int]
     source: Optional[Union[str, int]]
     dynamic_shape: Optional[bool]
+    equivalent_batch_size: Optional[int] = 64
 
 
 @dataclass
@@ -144,6 +145,7 @@ class Config:
     model: ModelConfig
     name: str
 
+    accelerator: Optional[str]
     device: Union[str, int, List[int]]
     cpu_num: int
 

yolo/config/general.yaml

@@ -1,4 +1,5 @@
-device: 0
+accelerator: auto
+device: auto
 cpu_num: 16
 
 image_size: [640, 640]

yolo/config/task/train.yaml

@@ -7,6 +7,7 @@ epoch: 500
 
 data:
   batch_size: 16
+  equivalent_batch_size: 64
   image_size: ${image_size}
   cpu_num: ${cpu_num}
   shuffle: True

yolo/lazy.py

@@ -17,16 +17,18 @@ def main(cfg: Config):
     callbacks, loggers, save_path = setup(cfg)
 
     trainer = Trainer(
-        accelerator="auto",
+        accelerator=getattr(cfg, "accelerator", "auto"),
+        devices=cfg.device,
         max_epochs=getattr(cfg.task, "epoch", None),
         precision="16-mixed",
         callbacks=callbacks,
+        sync_batchnorm=True,
         logger=loggers,
         log_every_n_steps=1,
         gradient_clip_val=10,
         gradient_clip_algorithm="norm",
         deterministic=True,
-        enable_progress_bar=not getattr(cfg, "quite", False),
+        enable_progress_bar=not getattr(cfg, "quiet", False),
         default_root_dir=save_path,
     )
 

yolo/utils/logging_utils.py

@@ -38,7 +38,7 @@
 from yolo.config.config import Config, YOLOLayer
 from yolo.model.yolo import YOLO
 from yolo.utils.logger import logger
-from yolo.utils.model_utils import EMA
+from yolo.utils.model_utils import EMA, GradientAccumulation
 from yolo.utils.solver_utils import make_ap_table
 
 
@@ -68,7 +68,6 @@ def _init_progress(self, trainer: "Trainer") -> None:
             self._reset_progress_bar_ids()
             reconfigure(**self._console_kwargs)
             self._console = Console()
-            self._console.clear_live()
             self.progress = YOLOCustomProgress(
                 *self.configure_columns(trainer),
                 auto_refresh=False,
@@ -105,7 +104,7 @@ def on_train_batch_end(self, trainer, pl_module, outputs, batch: Any, batch_idx:
         self._update(self.train_progress_bar_id, batch_idx + 1)
         self._update_metrics(trainer, pl_module)
         epoch_descript = "[cyan]Train [white]|"
-        batch_descript = "[green]Train [white]|"
+        batch_descript = "[green]Batch [white]|"
         metrics = self.get_metrics(trainer, pl_module)
         metrics.pop("v_num")
         for metrics_name, metrics_val in metrics.items():
@@ -238,7 +237,7 @@ def on_validation_batch_end(self, trainer: Trainer, pl_module, outputs, batch, b
                 logger.log_image("Prediction", images, step=step, boxes=[log_bbox(pred_boxes)])
 
 
-def setup_logger(logger_name, quite=False):
+def setup_logger(logger_name, quiet=False):
     class EmojiFormatter(logging.Formatter):
         def format(self, record, emoji=":high_voltage:"):
             return f"{emoji} {super().format(record)}"
@@ -249,17 +248,17 @@ def format(self, record, emoji=":high_voltage:"):
     if rich_logger:
         rich_logger.handlers.clear()
         rich_logger.addHandler(rich_handler)
-        if quite:
+        if quiet:
             rich_logger.setLevel(logging.ERROR)
 
     coco_logger = logging.getLogger("faster_coco_eval.core.cocoeval")
     coco_logger.setLevel(logging.ERROR)
 
 
 def setup(cfg: Config):
-    quite = hasattr(cfg, "quite")
-    setup_logger("lightning.fabric", quite=quite)
-    setup_logger("lightning.pytorch", quite=quite)
+    quiet = hasattr(cfg, "quiet")
+    setup_logger("lightning.fabric", quiet=quiet)
+    setup_logger("lightning.pytorch", quiet=quiet)
 
     def custom_wandb_log(string="", level=int, newline=True, repeat=True, prefix=True, silent=False):
         if silent:
@@ -273,9 +272,12 @@ def custom_wandb_log(string="", level=int, newline=True, repeat=True, prefix=Tru
 
     progress, loggers = [], []
 
+    if cfg.task.task == "train" and hasattr(cfg.task.data, "equivalent_batch_size"):
+        progress.append(GradientAccumulation(data_cfg=cfg.task.data, scheduler_cfg=cfg.task.scheduler))
+
     if hasattr(cfg.task, "ema") and cfg.task.ema.enable:
         progress.append(EMA(cfg.task.ema.decay))
-    if quite:
+    if quiet:
         logger.setLevel(logging.ERROR)
         return progress, loggers, save_path
 
@@ -336,7 +338,7 @@ def validate_log_directory(cfg: Config, exp_name: str) -> Path:
             )
 
     save_path.mkdir(parents=True, exist_ok=True)
-    if not getattr(cfg, "quite", False):
+    if not getattr(cfg, "quiet", False):
         logger.info(f"📄 Created log folder: [blue b u]{save_path}[/]")
     logger.addHandler(FileHandler(save_path / "output.log"))
     return save_path