From 2e0cab26deff544df29fb26fc7d14191149812e8 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:00:14 -0500 Subject: [PATCH 01/31] docker user --- .github/workflows/pythonapp.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index c3e5d3176..b4f99ad45 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -23,6 +23,6 @@ jobs: - name: Build & Push Image run: | cd ./python - echo "${{ secrets.DOCKERPW }}" | docker login -u "[your dockerhub login here]" --password-stdin - docker image build -t [your dockerhub username here]/gitops:hellov1.0 . - docker push [your docker hub username here]/gitops:hellov1.0 + echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin + docker image build -t nmbiren/gitops:hellov1.0 . + docker push nmbiren/gitops:hellov1.0 From 178848e21ab78c9be128a7549fc1d688ce020d5d Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:00:43 -0500 Subject: [PATCH 02/31] version update --- .github/workflows/pythonapp.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index b4f99ad45..18c134d01 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -24,5 +24,5 @@ jobs: run: | cd ./python echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin - docker image build -t nmbiren/gitops:hellov1.0 . - docker push nmbiren/gitops:hellov1.0 + docker image build -t nmbiren/gitops:hellov1.1 . + docker push nmbiren/gitops:hellov1.1 From 15bc34282c3ab60cb4ebca98ef73fcddeeb6d8c3 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:06:42 -0500 Subject: [PATCH 03/31] Update app.py --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index 358088e4c..6bdc7f24c 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello World!" + return "Hello LA Students!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 66d1fd9757aa1faeeda3563e243879dbdc5a93bf Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:09:03 -0500 Subject: [PATCH 04/31] Update app.py --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index 6bdc7f24c..1bbc599dc 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello LA Students!" + return "Hello LA Students Again!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 1f09209a78221e0ebd5b52e1e6d2b3078af7ca40 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:15:25 -0500 Subject: [PATCH 05/31] update docker repo --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 18c134d01..776d25159 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -25,4 +25,4 @@ jobs: cd ./python echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin docker image build -t nmbiren/gitops:hellov1.1 . - docker push nmbiren/gitops:hellov1.1 + docker push nmbiren/containerimages1:hellov1.1 From 550d2946e2cfdc60e07461c126683af0ad8a41fc Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:17:01 -0500 Subject: [PATCH 06/31] update username --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 776d25159..d2d3c7028 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -23,6 +23,6 @@ jobs: - name: Build & Push Image run: | cd ./python - echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin + echo "${{ secrets.DOCKERPW }}" | docker login -u nmbiren --password-stdin docker image build -t nmbiren/gitops:hellov1.1 . docker push nmbiren/containerimages1:hellov1.1 From 5f976a900725d08691594e5b5b05bfaecbf0c0ef Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:18:33 -0500 Subject: [PATCH 07/31] updated --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index 1bbc599dc..76c927fad 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello LA Students Again!" + return "Hello LA Students Again...Again!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 912c4ab1b8913df9e9ebd4d8eec87476da2e3e60 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:20:11 -0500 Subject: [PATCH 08/31] revert username, update version --- .github/workflows/pythonapp.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index d2d3c7028..843d1ed38 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -23,6 +23,6 @@ jobs: - name: Build & Push Image run: | cd ./python - echo "${{ secrets.DOCKERPW }}" | docker login -u nmbiren --password-stdin - docker image build -t nmbiren/gitops:hellov1.1 . - docker push nmbiren/containerimages1:hellov1.1 + echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin + docker image build -t nmbiren/gitops:hellov1.2 . + docker push nmbiren/containerimages1:hellov1.2 From 12920948e60a143ad55edd0e0195653594b577e9 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:21:16 -0500 Subject: [PATCH 09/31] updated --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index 76c927fad..13d788eee 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello LA Students Again...Again!" + return "Hello LA Students, 3rd time's a charm!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 55f0b58e657f68b02404c3c5dbd7bb85eeea1859 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:27:32 -0500 Subject: [PATCH 10/31] update image build path --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 843d1ed38..e3a567243 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -24,5 +24,5 @@ jobs: run: | cd ./python echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin - docker image build -t nmbiren/gitops:hellov1.2 . + docker image build -t nmbiren/containerimages1:hellov1.2 . docker push nmbiren/containerimages1:hellov1.2 From 396b9a5f31886497c344da10a5e139ef9627d432 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:28:55 -0500 Subject: [PATCH 11/31] updated again --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index 13d788eee..f6fd2aa79 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello LA Students, 3rd time's a charm!" + return "Hello LA Students, worky now?!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 9b6f779b6c57eccf2c54c135b40bbd4d61732ba9 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:31:48 -0500 Subject: [PATCH 12/31] pull command --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index e3a567243..b3374ac94 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -1,7 +1,7 @@ name: Python application on: - push: + pull: paths: - 'python/*' From 33cfdb5d9706fe9952e963f4120758a0328fc535 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Tue, 12 Jan 2021 18:33:37 -0500 Subject: [PATCH 13/31] updated return --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index f6fd2aa79..2576f2ac6 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello LA Students, worky now?!" + return "Hello LA Student!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 929e332045b1c284c9ebf3698abc54d7f36db176 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Wed, 13 Jan 2021 16:27:30 -0500 Subject: [PATCH 14/31] updated pull_request --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index b3374ac94..37ad23eb2 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -1,7 +1,7 @@ name: Python application on: - pull: + pull_request: paths: - 'python/*' From 8c345214024375061c6f261cb273885c4f9c3c88 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Wed, 13 Jan 2021 16:42:18 -0500 Subject: [PATCH 15/31] updated --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index 2576f2ac6..c47e5e07f 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello LA Student!" + return "Hello LA Student!!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 23888c05a5e10fa37b0dd4f5d50ffaa46471ccd1 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Wed, 13 Jan 2021 16:50:31 -0500 Subject: [PATCH 16/31] pull request --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index b3374ac94..37ad23eb2 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -1,7 +1,7 @@ name: Python application on: - pull: + pull_request: paths: - 'python/*' From a30076ad53549daa55516682c358bce28dd98e44 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Wed, 13 Jan 2021 17:05:53 -0500 Subject: [PATCH 17/31] updated docker pull --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 37ad23eb2..c4eb54f58 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -25,4 +25,4 @@ jobs: cd ./python echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin docker image build -t nmbiren/containerimages1:hellov1.2 . - docker push nmbiren/containerimages1:hellov1.2 + docker pull nmbiren/containerimages1:hellov1.2 From 0970cbc6f77811cabf1ad38dc3fae07e8c8afe51 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Wed, 13 Jan 2021 17:40:17 -0500 Subject: [PATCH 18/31] updated username --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index c4eb54f58..0d89e0a67 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -23,6 +23,6 @@ jobs: - name: Build & Push Image run: | cd ./python - echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin + echo "${{ secrets.DOCKERPW }}" | docker login -u nmbiren --password-stdin docker image build -t nmbiren/containerimages1:hellov1.2 . docker pull nmbiren/containerimages1:hellov1.2 From 354b0fb59b58158b8c10d57f713b90f1ab810288 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Wed, 13 Jan 2021 17:55:43 -0500 Subject: [PATCH 19/31] updated --- .github/workflows/pythonapp.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 37ad23eb2..0d89e0a67 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -23,6 +23,6 @@ jobs: - name: Build & Push Image run: | cd ./python - echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin + echo "${{ secrets.DOCKERPW }}" | docker login -u nmbiren --password-stdin docker image build -t nmbiren/containerimages1:hellov1.2 . - docker push nmbiren/containerimages1:hellov1.2 + docker pull nmbiren/containerimages1:hellov1.2 From 8c5ea0e8f77e0b5c7eb383b4d3cf7e0bf38df3b4 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Wed, 13 Jan 2021 18:00:00 -0500 Subject: [PATCH 20/31] update to push --- .github/workflows/pythonapp.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 0d89e0a67..1331a17a1 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -1,7 +1,7 @@ name: Python application on: - pull_request: + push: paths: - 'python/*' @@ -24,5 +24,5 @@ jobs: run: | cd ./python echo "${{ secrets.DOCKERPW }}" | docker login -u nmbiren --password-stdin - docker image build -t nmbiren/containerimages1:hellov1.2 . - docker pull nmbiren/containerimages1:hellov1.2 + docker image build -t nmbiren/containerimages1:hellov1.3 . + docker push nmbiren/containerimages1:hellov1.3 From a78eb1919fb32d2297437c298b7e281b41fde238 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Wed, 13 Jan 2021 18:01:36 -0500 Subject: [PATCH 21/31] Update pythonapp.yml --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 1331a17a1..d37ca13e2 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -23,6 +23,6 @@ jobs: - name: Build & Push Image run: | cd ./python - echo "${{ secrets.DOCKERPW }}" | docker login -u nmbiren --password-stdin + echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin docker image build -t nmbiren/containerimages1:hellov1.3 . docker push nmbiren/containerimages1:hellov1.3 From a9a43fc3f53700e40ed0fe4162b91c1b34c81e27 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Thu, 14 Jan 2021 14:24:29 -0500 Subject: [PATCH 22/31] updated docker login --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index d37ca13e2..9e0db23b1 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -23,6 +23,6 @@ jobs: - name: Build & Push Image run: | cd ./python - echo "${{ secrets.DOCKERPW }}" | docker login -u "nmbiren" --password-stdin + docker login --username=nmbiren --password=${{ secrets.DOCKERPW }} docker image build -t nmbiren/containerimages1:hellov1.3 . docker push nmbiren/containerimages1:hellov1.3 From eaae79ec7db3b0cad7f1a184da22788ad2ce2747 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Thu, 14 Jan 2021 14:25:18 -0500 Subject: [PATCH 23/31] Update app.py --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index 2576f2ac6..004e61a6a 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello LA Student!" + return "Hello!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From d7c9b628c58eada010a8b76a2607061ce2674e55 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Thu, 14 Jan 2021 16:01:37 -0500 Subject: [PATCH 24/31] updated version for pull_request --- .github/workflows/pythonapp.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 9e0db23b1..0177f9ff6 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -1,7 +1,7 @@ name: Python application on: - push: + pull_request: paths: - 'python/*' @@ -24,5 +24,5 @@ jobs: run: | cd ./python docker login --username=nmbiren --password=${{ secrets.DOCKERPW }} - docker image build -t nmbiren/containerimages1:hellov1.3 . - docker push nmbiren/containerimages1:hellov1.3 + docker image build -t nmbiren/containerimages1:hellov1.4 . + docker push nmbiren/containerimages1:hellov1.4 From ffa39f0da2f9c352abfba39a10f238a663f05393 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Thu, 14 Jan 2021 16:02:18 -0500 Subject: [PATCH 25/31] Update app.py --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index 004e61a6a..eb6559e9a 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello!" + return "Hello, please try again!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 67ea7dbb6d392cb644dbfe9f29bb797af0cedc82 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Sun, 17 Jan 2021 17:22:06 -0500 Subject: [PATCH 26/31] Update app.py --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index eb6559e9a..ee0b8ffb5 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello, please try again!" + return "Hello, this isn't working!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 6d5651046b47a17f1c809291463fce703087354c Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Sun, 17 Jan 2021 17:25:31 -0500 Subject: [PATCH 27/31] updated 1.5 --- .github/workflows/pythonapp.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 0177f9ff6..deac7ccd2 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -1,7 +1,7 @@ name: Python application on: - pull_request: + push: paths: - 'python/*' @@ -24,5 +24,5 @@ jobs: run: | cd ./python docker login --username=nmbiren --password=${{ secrets.DOCKERPW }} - docker image build -t nmbiren/containerimages1:hellov1.4 . - docker push nmbiren/containerimages1:hellov1.4 + docker image build -t nmbiren/containerimages1:hellov1.5 . + docker push nmbiren/containerimages1:hellov1.5 From 974128e9ddbf7b73582c41a91d78d5af55ed0ef3 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Sun, 17 Jan 2021 17:30:29 -0500 Subject: [PATCH 28/31] Update app.py --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index ee0b8ffb5..3e2271935 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello, this isn't working!" + return "Hello, still this isn't working!" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 56c427df95273faf8d62dfa0e7d52779555f3c72 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Sun, 17 Jan 2021 17:40:53 -0500 Subject: [PATCH 29/31] updated pull request --- .github/workflows/pythonapp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index deac7ccd2..e4d40eda9 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -1,7 +1,7 @@ name: Python application on: - push: + pull_request: paths: - 'python/*' From 81165c06767d05fab3b02cbca66aa4a657e53336 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Sun, 17 Jan 2021 17:41:38 -0500 Subject: [PATCH 30/31] Update app.py --- python/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/app.py b/python/app.py index c47e5e07f..60fe77d71 100644 --- a/python/app.py +++ b/python/app.py @@ -3,7 +3,7 @@ @app.route("/") def hello(): - return "Hello LA Student!!" + return "Hello, does this work?" if __name__ == "__main__": app.run(host='0.0.0.0', port=8000) From 8ce41b3ff88185ae1fc1488137a7a0f64a5aa9e8 Mon Sep 17 00:00:00 2001 From: nmbiren <77249609+nmbiren@users.noreply.github.com> Date: Sun, 17 Jan 2021 17:46:00 -0500 Subject: [PATCH 31/31] updated --- .github/workflows/pythonapp.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 0d89e0a67..e4d40eda9 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -23,6 +23,6 @@ jobs: - name: Build & Push Image run: | cd ./python - echo "${{ secrets.DOCKERPW }}" | docker login -u nmbiren --password-stdin - docker image build -t nmbiren/containerimages1:hellov1.2 . - docker pull nmbiren/containerimages1:hellov1.2 + docker login --username=nmbiren --password=${{ secrets.DOCKERPW }} + docker image build -t nmbiren/containerimages1:hellov1.5 . + docker push nmbiren/containerimages1:hellov1.5