Skip to content

Is it okay that elements are removed from framefaces list while iterating over it? #52

@hannarud

Description

@hannarud

In the file there is a for cycle over framefaces variable, and inside that cycle framefaces gets modified (faces that are already tracked are removed):

framefaces.remove(face)

I'm not sure if this behavior is okay, because it may mean we loose some of the frames? At the same time, it all is getting executed in while loop, so maybe in the end the data is not lost.
I might try to rewrite this, if the problem really exists. But maybe it's not.
Do you think it is a problem? Should it be fixed?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions