feature(): Add MethodTooLong inspection to vb.net

Author: Wolfgang Janz

CleanCode/src/CleanCode/CleanCode.csproj

@@ -178,6 +178,7 @@
     <Compile Include="Features\HollowNames\HollowNamesCheck.cs" />
     <Compile Include="Features\MethodNameNotMeaningful\MethodNameNotMeaningfulHighlighting.cs" />
     <Compile Include="Features\MethodNameNotMeaningful\MethodNameNotMeaningfulCheck.cs" />
+    <Compile Include="Features\MethodTooLong\MethodTooLongCheckVb.cs" />
     <Compile Include="Features\MethodTooLong\MethodTooLongHighlighting.cs">
       <SubType>Code</SubType>
     </Compile>

CleanCode/src/CleanCode/Features/MethodTooLong/MethodTooLongCheckVb.cs

@@ -0,0 +1,36 @@
+using CleanCode.Settings;
+using JetBrains.Application.Settings;
+using JetBrains.ReSharper.Daemon.Stages.Dispatcher;
+using JetBrains.ReSharper.Feature.Services.Daemon;
+using JetBrains.ReSharper.Psi.VB.Tree;
+using JetBrains.ReSharper.Psi.Tree;
+
+namespace CleanCode.Features.MethodTooLong
+{
+    [ElementProblemAnalyzer(typeof(IMethodDeclaration), HighlightingTypes = new []
+    {
+        typeof(MethodTooLongHighlighting)
+    })]
+    public class MethodTooLongCheckVb : ElementProblemAnalyzer<IMethodDeclaration>
+    {
+        protected override void Run(IMethodDeclaration element, ElementProblemAnalyzerData data, IHighlightingConsumer consumer)
+        {
+            var maxStatements = data.SettingsStore.GetValue((CleanCodeSettings s) => s.MaximumMethodStatements);
+            var maxDeclarations = data.SettingsStore.GetValue((CleanCodeSettings s) => s.MaximumDeclarationsInMethod);
+
+            var statementCount = element.CountChildren<IStatement>();
+            if (statementCount <= maxStatements)
+            {
+                // Only look in the method body for declarations, otherwise we see
+                // parameters + type parameters. We can ignore arrow expressions, as
+                // they must be a single expression and won't have declarations
+                var declarationCount = element.Block?.CountChildren<IDeclaration>() ?? 0;
+                if (declarationCount <= maxDeclarations)
+                    return;
+            }
+
+            var highlighting = new MethodTooLongHighlighting(element.GetNameDocumentRange());
+            consumer.AddHighlighting(highlighting);
+        }
+    }
+}

CleanCode/src/CleanCode/Features/MethodTooLong/MethodTooLongHighlighting.cs

@@ -4,14 +4,15 @@
 using JetBrains.DocumentModel;
 using JetBrains.ReSharper.Feature.Services.Daemon;
 using JetBrains.ReSharper.Psi.CSharp;
+using JetBrains.ReSharper.Psi.VB;
 
 [assembly: RegisterConfigurableSeverity(MethodTooLongHighlighting.SeverityID, null, 
     CleanCodeHighlightingGroupIds.CleanCode, "Method too long", "The method is bigger than it should be.",
     Severity.SUGGESTION, false)]
 
 namespace CleanCode.Features.MethodTooLong
 {
-    [ConfigurableSeverityHighlighting(SeverityID, CSharpLanguage.Name)]
+    [ConfigurableSeverityHighlighting(SeverityID, CSharpLanguage.Name + VBLanguage.Name)]
     public class MethodTooLongHighlighting : IHighlighting
     {
         internal const string SeverityID = "MethodTooLong";