From a70a17e38da58631152d0e4eaf7df04a7b13f4b6 Mon Sep 17 00:00:00 2001 From: Diego Date: Wed, 15 Apr 2026 13:35:15 -0400 Subject: [PATCH 1/2] fix(generator): fall back to java.lang.Object for unknown types. --- generator/src/googleapis/codegen/java_generator.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/generator/src/googleapis/codegen/java_generator.py b/generator/src/googleapis/codegen/java_generator.py index 609f1782a20..f017edb7ada 100755 --- a/generator/src/googleapis/codegen/java_generator.py +++ b/generator/src/googleapis/codegen/java_generator.py @@ -261,12 +261,10 @@ def _GetTypeInfo(self, def_dict): if result: return result - # TODO(user): Uncomment this and update golden files. - # result = self.type_map.get((json_type, None)) - # if result: - # return result - # - # raise ValueError('Unknown type: %s format: %s' % (json_type, json_format)) + # Fallback to the unformatted base type if exact format mapping is not found. + result = self.type_map.get((json_type, None)) + if result: + return result return (utilities.CamelCase(json_type), None, None) From f113797a4358081037597832f8a0d6f68327a3f3 Mon Sep 17 00:00:00 2001 From: Diego Date: Thu, 16 Apr 2026 09:45:03 -0400 Subject: [PATCH 2/2] test(generator): assert safe fallback mapping for Any formatted structures --- generator/tests/java_generator_test.py | 1 + 1 file changed, 1 insertion(+) diff --git a/generator/tests/java_generator_test.py b/generator/tests/java_generator_test.py index 99cd443690f..d9b9e766909 100755 --- a/generator/tests/java_generator_test.py +++ b/generator/tests/java_generator_test.py @@ -84,6 +84,7 @@ def testGetCodeTypeFromDictionary(self): ['java.lang.Integer', {'type': 'integer', 'format': 'int32'}], ['java.lang.Long', {'type': 'string', 'format': 'int64'}], ['java.lang.Object', {'type': 'any'}], + ['java.lang.Object', {'type': 'any', 'format': 'google.protobuf.Value'}], ['java.lang.Boolean', {'type': 'boolean'}], ['java.lang.String', {'type': 'string'}], ['java.lang.Long', {'type': 'integer', 'format': 'uint32'}],