The feedback on this commit from several years ago was correct:
67f8ed3
by modifying the root logger like this, you're actually modifying the log level used by any other library that they pull in that has logging on NOSET. For example, this causes urllib3 to emit at DEBUG level, regardless of what level the consuming function is set to, unless they specifically override the root level logging themselves.
I'm not sure I follow the intent here, based on the commit message. It doesn't seem to be preserving the logging behaviour of the previous code? I would expect this to be gated by the same fdk_debug flag as it was before.
I'd probably argue that fdk shouldn't really be setting root logging to debug, that should be an explicit end user decision in their own code, with their own choice of gate around it. Let fdk_debug just gate fdk's own log level.
The feedback on this commit from several years ago was correct:
67f8ed3
by modifying the root logger like this, you're actually modifying the log level used by any other library that they pull in that has logging on NOSET. For example, this causes urllib3 to emit at DEBUG level, regardless of what level the consuming function is set to, unless they specifically override the root level logging themselves.
I'm not sure I follow the intent here, based on the commit message. It doesn't seem to be preserving the logging behaviour of the previous code? I would expect this to be gated by the same fdk_debug flag as it was before.
I'd probably argue that fdk shouldn't really be setting root logging to debug, that should be an explicit end user decision in their own code, with their own choice of gate around it. Let fdk_debug just gate fdk's own log level.