Prevent crash when decoding binary multipart request bodies#9680
Merged
srawlins merged 4 commits intoflutter:masterfrom Mar 3, 2026
Merged
Prevent crash when decoding binary multipart request bodies#9680srawlins merged 4 commits intoflutter:masterfrom
srawlins merged 4 commits intoflutter:masterfrom
Conversation
rishika0212
requested review from
a team,
bkonyi and
kenzieschmoll
as code owners
srawlins
approved these changes
Mar 2, 2026
Contributor
srawlins
left a comment
srawlins
left a comment
There was a problem hiding this comment.
I think this looks great; thanks much!
Contributor
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9626
DevTools previously attempted to decode all request and response
bodies using utf8.decode(), which throws a FormatException when
binary data (e.g., multipart file uploads such as PDFs) is encountered.
This change:
• Adds defensive UTF-8 decoding for UI display
• Caches a descriptive placeholder for non-text binary bodies
• Preserves raw byte buffers for accurate HAR export
• Ensures binary bodies are Base64 encoded in HAR output
with the required encoding: "base64" field (HAR 1.2 spec)
Valid UTF-8 responses are unaffected.
This prevents the Network screen from hanging when viewing
multipart requests containing binary payloads while maintaining
correct export behavior.