build_image: Allow specifying which OEM sysexts to build#3983
Open
build_image: Allow specifying which OEM sysexts to build#3983
Conversation
chewi
requested changes
Apr 28, 2026
Member
Author
Sure, whatever you do, it shouldn't affect my additions as long as |
Useful if we want to locally generate one kind of image for testing. Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
krnowak
force-pushed
the
krnowak/select-oem-sysext
branch
from
c0ba6fa to
11fc14f
Compare
chewi
requested changes
Apr 28, 2026
| if [[ ${#invalid_oems[@]} -gt 0 ]]; then | ||
| die "Requested OEMs to build sysexts for are invalid: ${invalid_oems[*]}, valid OEMs are ${all_oems[*]}" | ||
| fi | ||
| mapfile -t oem_sysexts < <(printf '%s\n' "${oem_sysexts[@]}" | grep '|\('"${requested_oem_sysexts_csv//,/'\|'}"'\)$') |
Contributor
There was a problem hiding this comment.
I think this is matching the last field? That's the USE flag field rather than the name field, which is first. I'm also killing OEM sysext USE flags, so this field will be empty.
Member
Author
There was a problem hiding this comment.
Yeah, I used the field that had the OEM name. I'll use the first field then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful if we want to locally generate one kind of image for testing.
Tested locally for building qemu OEM sysext only.