From 597a51e4831a27ebf390ed03eb4df37a66283a34 Mon Sep 17 00:00:00 2001 From: Yixin Wei Date: Tue, 21 Apr 2026 06:33:53 -0700 Subject: [PATCH] bump go version to 1.24 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Unbreak GH lint check, which fails on D100332220 because it uses `strings.SplitSeq` (Go 1.24+) but the github mirror was pinned to 1.23. Going to 1.24 (not 1.26 to match internal) because the github toolchain ecosystem isn't there yet — golangci-lint v1.64.8 was built with Go 1.24 and Fedora packit ships Go 1.25.9, so a 1.26 bump breaks both. 1.24 is the minimum to allow `strings.SplitSeq` while keeping downstream consumers happy. Differential Revision: D101807455 --- .github/workflows/lint.yml | 2 +- .github/workflows/test.yml | 2 +- go.mod | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index a80deef6..51679015 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -7,7 +7,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 with: - go-version: 1.23 + go-version: 1.24 - run: sudo apt-get install libpcap-dev - uses: golangci/golangci-lint-action@v3 - run: | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8b5b8d8d..a8f88d38 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,7 +7,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 with: - go-version: 1.23 + go-version: 1.24 - run: sudo apt-get install libpcap-dev libcap2-bin - run: go build -v ./... # fuzzing, need to specify each package separately diff --git a/go.mod b/go.mod index b8f89ada..60bc3fef 100644 --- a/go.mod +++ b/go.mod @@ -1,8 +1,8 @@ module github.com/facebook/time -go 1.23.0 +go 1.24.0 -toolchain go1.23.7 +toolchain go1.24.0 require ( github.com/Knetic/govaluate v3.0.0+incompatible