Skip to content

Fix determin banking value#2360

Merged
mariusheine merged 4 commits intomainfrom
fix-determin-banking-value
Apr 23, 2026
Merged

Fix determin banking value#2360
mariusheine merged 4 commits intomainfrom
fix-determin-banking-value

Conversation

@TruongQuangSB
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Test Results

133 tests  ±0   133 ✅ ±0   49s ⏱️ -11s
 33 suites ±0     0 💤 ±0 
 33 files   ±0     0 ❌ ±0 

Results for commit 60e3f5f. ± Comparison against base commit 5fba7f9.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@74170687
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@1e9469b8
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@5f254608
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@1b1c538d
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@6325f352
org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test3441109470078944555PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
org.eclipse.set.feature.siteplan.transform.SiteplanTransformatorTest ‑ testSiteplanTransformSuccessful(String)[1] /tmp/set-test9843735323090484525PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@254513e8, expected=multi/container-id/1539392017/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@74f89bad, expected=multi/456/1563321789/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@390a07a0, second=other], expected=multi/container-id/220371218/element-id/other=other]
…
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@ec8f4b9
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@1457fde
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@2630dbc4
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@5a1c3cb4
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@56637cff
org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test2439518834039069665PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
org.eclipse.set.feature.siteplan.transform.SiteplanTransformatorTest ‑ testSiteplanTransformSuccessful(String)[1] /tmp/set-test12077209808077871458PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@20155dae, expected=multi/container-id/701279123/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@417bfebd, expected=multi/456/616080275/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@6f80cf5, second=other], expected=multi/container-id/715194034/element-id/other=other]
…

♻️ This comment has been updated with latest results.

@mariusheine
Copy link
Copy Markdown
Contributor

@TruongQuangSB I don't quite get it where the new zeros are coming from (see table diffs #2362)... Can you please tell me because there still are empty cells in PHausen?

@TruongQuangSB
Copy link
Copy Markdown
Contributor Author

I don't quite get it where the new zeros are coming from (see table diffs #2362)... Can you please tell me because there still are empty cells in PHausen?

@TruongQuangSB I don't quite get it where the new zeros are coming from (see table diffs #2362)... Can you please tell me because there still are empty cells in PHausen?

@mariusheine yes, the determine TopPath first edge length and the caculation of banking length was wrong. Because of this in PHausen was empty cell rendered

@mariusheine
Copy link
Copy Markdown
Contributor

I don't quite get it where the new zeros are coming from (see table diffs #2362)... Can you please tell me because there still are empty cells in PHausen?

@TruongQuangSB I don't quite get it where the new zeros are coming from (see table diffs #2362)... Can you please tell me because there still are empty cells in PHausen?

@mariusheine yes, the determine TopPath first edge length and the caculation of banking length was wrong. Because of this in PHausen was empty cell rendered

So I can safely update the table references?

@TruongQuangSB
Copy link
Copy Markdown
Contributor Author

I don't quite get it where the new zeros are coming from (see table diffs #2362)... Can you please tell me because there still are empty cells in PHausen?

@TruongQuangSB I don't quite get it where the new zeros are coming from (see table diffs #2362)... Can you please tell me because there still are empty cells in PHausen?

@mariusheine yes, the determine TopPath first edge length and the caculation of banking length was wrong. Because of this in PHausen was empty cell rendered

So I can safely update the table references?

i think so, else u can testen with Lageplan

@mariusheine mariusheine merged commit bada8e6 into main Apr 23, 2026
15 checks passed
@mariusheine mariusheine deleted the fix-determin-banking-value branch April 23, 2026 14:49
TruongQuangSB added a commit to SuB-PlanPro/set that referenced this pull request Apr 24, 2026
* Fix dertermin Bank value

* fix

* Update table reference

---------

Co-authored-by: Marius Heine <m.heine@geprog.com>
Co-authored-by: eclipse-set-bot <set-bot@eclipse.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants