fix: resolve all ruff and mypy linting issues

- Fix nested if statements (SIM102) in plugin and update commands
- Remove unused subprocess result variables (F841)
- Fix mutable class attribute using Field(default_factory=list) (RUF012)
- Add proper type annotations for Click context and JSON parsing
- Fix nullable type handling in plugin search logic
- Ensure all code passes black, ruff, and mypy checks

Author: lukeocodes

packages/deepctl-cmd-plugin/src/deepctl_cmd_plugin/command.py

@@ -83,7 +83,7 @@ def context_wrapper(func: Any) -> Any:
             """Wrap subcommand to provide config and auth."""
 
             @click.pass_context
-            def wrapper(ctx: click.Context, **kwargs: Any) -> Any:
+            def wrapper(ctx: click.Context, /, **kwargs: Any) -> Any:
                 # Try to get from parent context first
                 if ctx.parent and ctx.parent.obj:
                     config = ctx.parent.obj.get("config")
@@ -93,7 +93,7 @@ def wrapper(ctx: click.Context, **kwargs: Any) -> Any:
                         return func(config, auth_manager, client, **kwargs)
 
                 # Fallback - look for deepctl_context
-                current_ctx = ctx
+                current_ctx: click.Context | None = ctx
                 while current_ctx:
                     if hasattr(current_ctx, "deepctl_context"):
                         config = current_ctx.deepctl_context.get("config")
@@ -187,7 +187,10 @@ def _get_plugin_state(self) -> dict[str, Any]:
         """
         if self._plugin_state_file.exists():
             try:
-                return json.loads(self._plugin_state_file.read_text())
+                result: dict[str, Any] = json.loads(
+                    self._plugin_state_file.read_text()
+                )
+                return result
             except Exception:
                 return {"plugins": {}}
         return {"plugins": {}}
@@ -399,11 +402,10 @@ def _handle_remove(
         package = kwargs["package"]
         yes = kwargs.get("yes", False)
 
-        if not yes:
-            if not click.confirm(
-                f"Are you sure you want to remove {package}?"
-            ):
-                return
+        if not yes and not click.confirm(
+            f"Are you sure you want to remove {package}?"
+        ):
+            return
 
         result = self.remove_plugin(config, auth_manager, client, package)
 
@@ -476,13 +478,15 @@ def _handle_search(
 
             # Check installed status
             is_installed = (
-                plugin.install_name in installed_plugins
-                or plugin.name in installed_plugins
-            )
+                plugin.install_name is not None
+                and plugin.install_name in installed_plugins
+            ) or plugin.name in installed_plugins
             installed_version = None
             if is_installed:
-                installed_plugin = installed_plugins.get(
-                    plugin.install_name
+                installed_plugin = (
+                    installed_plugins.get(plugin.install_name)
+                    if plugin.install_name
+                    else None
                 ) or installed_plugins.get(plugin.name)
                 if installed_plugin:
                     installed_version = installed_plugin.version
@@ -689,9 +693,7 @@ def install_plugin(
         # Execute installation
         try:
             print_info(f"Installing {options.package}...")
-            result = subprocess.run(
-                cmd, capture_output=True, text=True, check=True
-            )
+            subprocess.run(cmd, capture_output=True, text=True, check=True)
 
             # Get installed version
             installed_version = self._get_package_version(
@@ -883,9 +885,7 @@ def remove_plugin(
         # Execute removal
         try:
             print_info(f"Removing {package}...")
-            result = subprocess.run(
-                cmd, capture_output=True, text=True, check=True
-            )
+            subprocess.run(cmd, capture_output=True, text=True, check=True)
 
             # Update plugin state if using plugin environment
             if using_plugin_env:

packages/deepctl-cmd-plugin/src/deepctl_cmd_plugin/models.py

@@ -3,6 +3,7 @@
 from enum import Enum
 
 from deepctl_core.models import BaseModel
+from pydantic import Field
 
 
 class PluginAction(str, Enum):
@@ -35,7 +36,7 @@ class PluginRegistryEntry(BaseModel):
     version: str
     author: str | None = None
     url: str | None = None
-    keywords: list[str] = []
+    keywords: list[str] = Field(default_factory=list)
     # Package name for installation if different from name
     install_name: str | None = None
 

packages/deepctl-cmd-update/src/deepctl_cmd_update/command.py

@@ -158,19 +158,20 @@ def handle(
         console.print(f"\nUpdate command: [green]{update_command}[/green]")
 
         # Confirm update
-        if not yes:
-            if not Confirm.ask("\nDo you want to proceed with the update?"):
-                print_info("Update cancelled")
-                return UpdateResult(
-                    success=False,
-                    message="Update cancelled by user",
-                    current_version=version_info.current_version,
-                    latest_version=version_info.latest_version,
-                    update_available=version_info.update_available,
-                    installation_method=install_info.method,
-                ).model_dump()
+        if not yes and not Confirm.ask(
+            "\nDo you want to proceed with the update?"
+        ):
+            print_info("Update cancelled")
+            return UpdateResult(
+                success=False,
+                message="Update cancelled by user",
+                current_version=version_info.current_version,
+                latest_version=version_info.latest_version,
+                update_available=version_info.update_available,
+                installation_method=install_info.method,
+            ).model_dump()
 
-                # Execute update
+            # Execute update
         print_info("Updating deepctl...")
         try:
             # Run the update command synchronously