From e2c853da525be849496c8fc648240996952d8163 Mon Sep 17 00:00:00 2001 From: George Stagas Date: Thu, 13 Dec 2012 16:12:09 +0200 Subject: [PATCH 01/13] allow menu item to be handled before `hide` --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index fd19118..0e51d2d 100644 --- a/index.js +++ b/index.js @@ -154,10 +154,10 @@ Menu.prototype.add = function(text, fn){ .click(function(e){ e.preventDefault(); e.stopPropagation(); - self.hide(); self.emit('select', slug); self.emit(slug); fn && fn(); + self.hide(); }); this.items[slug] = el; From 756bef3288cde0b061ad3fdeff30e33e26910e9c Mon Sep 17 00:00:00 2001 From: George Stagas Date: Tue, 5 Mar 2013 23:12:48 +0200 Subject: [PATCH 02/13] bunch of improvements --- Makefile | 6 +- component.json | 6 +- index.js | 414 +++++++++++++++++++++++++++++++++++++++++++----- menu.css | 1 + test/index.html | 39 ++++- 5 files changed, 415 insertions(+), 51 deletions(-) diff --git a/Makefile b/Makefile index 00bb7f9..4d6f783 100644 --- a/Makefile +++ b/Makefile @@ -1,9 +1,9 @@ build: index.js components - @component build + @component build --dev -components: - @component install +components: component.json + @component install --dev clean: rm -fr build components diff --git a/component.json b/component.json index 6042766..e2d0859 100644 --- a/component.json +++ b/component.json @@ -8,7 +8,11 @@ ], "dependencies": { "component/emitter": "*", - "component/jquery": "*" + "component/jquery": "*", + "pazguille/viewport": "*" + }, + "development": { + "stagas/watch-js": "*" }, "styles": [ "menu.css" diff --git a/index.js b/index.js index 0e51d2d..07f71f6 100644 --- a/index.js +++ b/index.js @@ -4,6 +4,7 @@ */ var Emitter = require('emitter') + , viewport = require('viewport') , o = require('jquery'); /** @@ -29,12 +30,11 @@ module.exports = Menu; function Menu() { if (!(this instanceof Menu)) return new Menu; Emitter.call(this); - this.items = {}; + this.items = []; this.el = o('