Skip to content

Fix/window path #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jong-kyung wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/window path #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
610e0b1
fix: enhance toCleanPath for better Windows drive handling
Feb 5, 2026
2b33a47
fix: add test for handling missing drive letter in Windows path in to…
Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/create/src/file-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { basename, extname, resolve } from 'node:path'
import parseGitignore from 'parse-gitignore'
import ignore from 'ignore'

import { hasDrive, stripDrive } from './utils'
import type { Environment } from './types'

const BINARY_EXTENSIONS = ['.png', '.jpg', '.jpeg', '.gif', '.svg', '.ico']
Expand Down Expand Up @@ -43,7 +44,17 @@ export function toCleanPath(absolutePath: string, baseDir: string): string {
// Normalize both paths to use forward slashes for consistent comparison
const normalizedPath = absolutePath.replace(/\\/g, '/')
const normalizedBase = baseDir.replace(/\\/g, '/')
let cleanPath = normalizedPath.replace(normalizedBase, '')
let cleanPath = normalizedPath
if (normalizedPath.startsWith(normalizedBase)) {
cleanPath = normalizedPath.slice(normalizedBase.length)
} else if (hasDrive(normalizedPath) !== hasDrive(normalizedBase)) {
// Handle paths that are missing the Windows drive letter (e.g. memfs on Windows)
const pathNoDrive = stripDrive(normalizedPath)
const baseNoDrive = stripDrive(normalizedBase)
if (pathNoDrive.startsWith(baseNoDrive)) {
cleanPath = pathNoDrive.slice(baseNoDrive.length)
}
}
// Handle leading path separator
if (cleanPath.startsWith('/')) {
cleanPath = cleanPath.slice(1)
Expand Down
8 changes: 8 additions & 0 deletions packages/create/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,11 @@ export function handleSpecialURL(url: string) {
}
return url
}

export function hasDrive(path: string) {
return /^[A-Za-z]:/.test(path)
}

export function stripDrive(path: string) {
return path.replace(/^[A-Za-z]:/, '')
}
6 changes: 6 additions & 0 deletions packages/create/tests/file-helper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ describe('toCleanPath', () => {
toCleanPath('C:\\Projects\\my-app\\src\\file.ts', 'C:/Projects/my-app'),
).toBe('src/file.ts')
})

it('should handle missing drive letter in path against Windows base', () => {
expect(
toCleanPath('/Users/me/my-app/src/file.ts', 'C:\\Users\\me\\my-app'),
).toBe('src/file.ts')
})
})

describe('relativePath', () => {
Expand Down