SONARPY-4120 Ruling Diff Comment: support rule with legacy key (#1081)

GitOrigin-RevId: 6f838e0f5531078e6f595cdfece99a0b06b404ad

Author: joke1196

.github/actions/ruling-diff-comment/ruling_diff_core_lib/ruling_diff_logic.py

@@ -44,8 +44,8 @@ def parse_rule_filename(filename: str) -> tuple[str, str]:
     repository, rule_key = basename.rsplit("-", 1)
     if not repository:
         raise ValueError(f"Missing repo in filename: {filename}")
-    if not rule_key.startswith("S") or not rule_key[1:].isdigit():
-        raise ValueError(f"Invalid rule key in filename: {filename}")
+    if not rule_key:
+        raise ValueError(f"Missing rule key in filename: {filename}")
     return repository, rule_key
 
 

.github/actions/ruling-diff-comment/test_ruling_diff.py

@@ -56,6 +56,21 @@ def test_parse_ruling_path_with_pythonenterprise(self) -> None:
             core.parse_ruling_path(path),
         )
 
+    def test_parse_ruling_path_with_legacy_key(self) -> None:
+        path = "private/its-enterprise/ruling/src/test/resources/expected_ruling/scikit-learn/python-LineLength.json"
+        self.assertEqual(
+            ("scikit-learn", "python", "LineLength"),
+            core.parse_ruling_path(path),
+        )
+
+    def test_parse_rule_filename_rejects_empty_rule_key(self) -> None:
+        with self.assertRaises(ValueError):
+            core.parse_rule_filename("python-.json")
+
+    def test_parse_rule_filename_rejects_empty_repository(self) -> None:
+        with self.assertRaises(ValueError):
+            core.parse_rule_filename("-S1066.json")
+
 
 class DiffLogicTest(unittest.TestCase):
     def test_diff_ruling_jsons_added_issues(self) -> None:
@@ -408,9 +423,7 @@ def test_resolve_source_path_for_project_rulings_falls_back_to_sources_child(sel
             io_impl.resolve_source_path("project", "S1716.py"),
         )
 
-    def test_resolve_source_path_for_project_rulings_falls_back_to_sources_internal(
-        self,
-    ) -> None:
+    def test_resolve_source_path_for_project_rulings_falls_back_to_sources_internal(self) -> None:
         io_impl = io.GitHubActionIO()
         with tempfile.TemporaryDirectory() as tmp_dir:
             sources_ruling = f"{tmp_dir}/sources_ruling"
@@ -432,9 +445,7 @@ def test_resolve_source_path_for_project_rulings_falls_back_to_sources_internal(
             ):
                 self.assertEqual(target, io_impl.resolve_source_path("project", "foo.py"))
 
-    def test_resolve_source_path_for_project_rulings_falls_back_to_namespace_child(
-        self,
-    ) -> None:
+    def test_resolve_source_path_for_project_rulings_falls_back_to_namespace_child(self) -> None:
         io_impl = io.GitHubActionIO()
         with tempfile.TemporaryDirectory() as tmp_dir:
             sources_ruling = f"{tmp_dir}/sources_ruling"