[Bug] Next dark theme improvement

[sebojolais]

Describe the bug

I think the current implementation of the dark theme mixes two topics:

• the dark theme of the GUI of OB
• the black board mode (when you have no white board but an old black board)

To Reproduce

1. Get OB from the current dev branch
2. Switch your OS to black theme
3. Launch OB in the board view
4. The tool bar, the menu bar and the border of elements are adapted for dark theme, event if we set the background in white board
5. Have a look at the screenshot:

From my point of view, it does not make sense to show dark theme on a white board. And from my experience, the usability regresses because the icons are less identifiable.

Expected behavior

I think the board view should switch between light and dark mode with the background light or dark board. But not with the OS dark theme.

Context

• reproducibility : systematic
• OpenBoard version :
  • bug happens with : `1.7.6 dev branch
  • didn't check : 1.6.4 1.7.0
• OS :
  • bug happens with :Linux
  • didn't check : Windows macOS
• If you built OpenBoard from source, please provide the branch you're working on : dev

Additional context

• OS(es) detailed version (for the ones you reproduced the bug on) :
  • Linux : Description: Ubuntu 22.04.6 LTS with KDE
• number and resolution of monitors : 1

[kaamui]

I disagree, but we could make it an option : "theme follows background mode"

[sebojolais]

Ok, I agree that there are different point of view ;-) So an option will be helpful.

At least, we have to create new icones for the dark theme on the tool bar. Currently I do not see them very well when I am in front of the IWB.

And maybe a test directly on an Interractive White Board not only on laptop is relevant, the contrast is lower in this case.
Thank you for your answer.