From 06819cb66018b32017a161785a4726b9edf36eb9 Mon Sep 17 00:00:00 2001
From: Pritiks23 <pvipin23@uw.edu>
Date: Mon, 20 Apr 2026 10:08:14 -0700
Subject: [PATCH] Remove duplicate TestTransformValidator and fix test
 placement

---
 controllers/object_controls_test.go | 97 -----------------------------
 1 file changed, 97 deletions(-)

diff --git a/controllers/object_controls_test.go b/controllers/object_controls_test.go
index ba7206834..f48b58d8a 100644
--- a/controllers/object_controls_test.go
+++ b/controllers/object_controls_test.go
@@ -1889,100 +1889,3 @@ func TestMIGManager(t *testing.T) {
 	}
 }
 
-// TestDriverPrecompiledLibModulesUbuntu tests that /lib/modules is NOT mounted for precompiled drivers on Ubuntu
-func TestDriverPrecompiledLibModulesUbuntu(t *testing.T) {
-	cp := getDriverTestInput("precompiled")
-	output := getDriverTestOutput("precompiled")
-
-	ds, err := testDaemonsetCommon(t, cp, "Driver", output["numDaemonsets"].(int))
-	if err != nil {
-		t.Fatalf("error in testDaemonsetCommon(): %v", err)
-	}
-	require.NotNil(t, ds)
-
-	// Check that /lib/modules volume and mount are NOT present
-	for _, vol := range ds.Spec.Template.Spec.Volumes {
-		require.NotEqual(t, "lib-modules", vol.Name, "lib-modules volume should not be present for ubuntu")
-	}
-
-	driverContainer := findContainerByName(ds.Spec.Template.Spec.Containers, "nvidia-driver-ctr")
-	require.NotNil(t, driverContainer)
-
-	for _, mount := range driverContainer.VolumeMounts {
-		require.NotEqual(t, "lib-modules", mount.Name, "lib-modules volume mount should not be present for ubuntu")
-	}
-
-	// Cleanup
-	err = removeState(&clusterPolicyController, clusterPolicyController.idx-1)
-	if err != nil {
-		t.Fatalf("error removing state %v:", err)
-	}
-	clusterPolicyController.idx--
-}
-
-// TestDriverPrecompiledLibModulesSuse tests that /lib/modules is mounted for precompiled drivers on SLES and SL-Micro
-func TestDriverPrecompiledLibModulesSuse(t *testing.T) {
-	osTags := []string{"sles16.0", "sl-micro6.1"}
-
-	for _, osTag := range osTags {
-		t.Run(osTag, func(t *testing.T) {
-			// Save original OS info and restore after test
-			originalOSRelease := clusterPolicyController.gpuNodeOSRelease
-			originalOSTag := clusterPolicyController.gpuNodeOSTag
-			defer func() {
-				clusterPolicyController.gpuNodeOSRelease = originalOSRelease
-				clusterPolicyController.gpuNodeOSTag = originalOSTag
-			}()
-
-			switch {
-			case strings.HasPrefix(osTag, "sles"):
-				clusterPolicyController.gpuNodeOSRelease = "sles"
-			case strings.HasPrefix(osTag, "sl-micro"):
-				clusterPolicyController.gpuNodeOSRelease = "sl-micro"
-			default:
-				t.Fatalf("unsupported SUSE osTag in test: %s", osTag)
-			}
-			clusterPolicyController.gpuNodeOSTag = osTag
-
-			cp := getDriverTestInput("precompiled")
-			output := getDriverTestOutput("precompiled")
-
-			ds, err := testDaemonsetCommon(t, cp, "Driver", output["numDaemonsets"].(int))
-			if err != nil {
-				t.Fatalf("error in testDaemonsetCommon(): %v", err)
-			}
-			require.NotNil(t, ds)
-
-			// Check for /lib/modules volume and mount
-			foundVolume := false
-			for _, vol := range ds.Spec.Template.Spec.Volumes {
-				if vol.Name == "lib-modules" {
-					foundVolume = true
-					require.NotNil(t, vol.HostPath)
-					require.Equal(t, "/lib/modules", vol.HostPath.Path)
-				}
-			}
-			require.Truef(t, foundVolume, "lib-modules volume not found for precompiled drivers on %s", osTag)
-
-			foundMount := false
-			driverContainer := findContainerByName(ds.Spec.Template.Spec.Containers, "nvidia-driver-ctr")
-			require.NotNil(t, driverContainer)
-
-			for _, mount := range driverContainer.VolumeMounts {
-				if mount.Name == "lib-modules" {
-					foundMount = true
-					require.Equal(t, "/run/host/lib/modules", mount.MountPath)
-					require.True(t, mount.ReadOnly)
-				}
-			}
-			require.Truef(t, foundMount, "lib-modules volume mount not found for precompiled drivers on %s", osTag)
-
-			// Cleanup
-			err = removeState(&clusterPolicyController, clusterPolicyController.idx-1)
-			if err != nil {
-				t.Fatalf("error removing state %v:", err)
-			}
-			clusterPolicyController.idx--
-		})
-	}
-}