fix(images): remove image-specific owner and mode set for gateway binary#1371
Merged
Merged
Conversation
sjenning
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
|
Label |
Collaborator
|
/ok to test 640a345 |
TaylorMutch
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
--chown=nvs:nvs --chmod=0550flags from the gateway DockerfileCOPYinstruction.If the user overrides the user ID in the helm values or the UID can't be controlled, as is the case with OpenShift, this will break. This preserves the original 0755 mode and, since it is world executable, there is no need to
chown.Changes
--chown=nvs:nvs --chmod=0550from the gateway binaryCOPYinstruction indeploy/docker/Dockerfile.gatewayTesting
mise run pre-commitpassesChecklist