Skip to content

Commit 8a9d9bd

Browse files
--wip-- [skip ci]
1 parent fc169f7 commit 8a9d9bd

2 files changed

Lines changed: 23 additions & 23 deletions

File tree

src/executor/wall_time/executor.rs

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -105,28 +105,28 @@ impl WallTimeExecutor {
105105
bench_cmd.arg(script_file.path());
106106
let (mut bench_cmd, env_file) = wrap_with_env(bench_cmd, &extra_env)?;
107107

108-
let mut cmd_builder = CommandBuilder::new("systemd-run");
109-
if let Some(cwd) = &config.working_directory {
110-
let abs_cwd = canonicalize(cwd)?;
111-
cmd_builder.current_dir(abs_cwd);
112-
}
113-
if !is_codspeed_debug_enabled() {
114-
cmd_builder.arg("--quiet");
115-
}
116-
// Remarks:
117-
// - We're using --scope so that perf is able to capture the events of the benchmark process.
118-
// - We can't user `--user` here because we need to run in `codspeed.slice`, otherwise we'd run in
119-
// user.slice` (which is isolated). We can use `--gid` and `--uid` to run the command as the current user.
120-
// - We must use `bash` here instead of `sh` since `source` isn't available when symlinked to `dash`.
121-
// - We have to pass the environment variables because `--scope` only inherits the system and not the user environment variables.
122-
cmd_builder.arg("--slice=codspeed.slice");
123-
cmd_builder.arg("--scope");
124-
cmd_builder.arg("--same-dir");
125-
cmd_builder.arg(format!("--uid={}", nix::unistd::Uid::current().as_raw()));
126-
cmd_builder.arg(format!("--gid={}", nix::unistd::Gid::current().as_raw()));
127-
cmd_builder.args(["--"]);
128-
129-
bench_cmd.wrap_with(cmd_builder);
108+
// let mut cmd_builder = CommandBuilder::new("systemd-run");
109+
// if let Some(cwd) = &config.working_directory {
110+
// let abs_cwd = canonicalize(cwd)?;
111+
// cmd_builder.current_dir(abs_cwd);
112+
// }
113+
// if !is_codspeed_debug_enabled() {
114+
// cmd_builder.arg("--quiet");
115+
// }
116+
// // Remarks:
117+
// // - We're using --scope so that perf is able to capture the events of the benchmark process.
118+
// // - We can't user `--user` here because we need to run in `codspeed.slice`, otherwise we'd run in
119+
// // user.slice` (which is isolated). We can use `--gid` and `--uid` to run the command as the current user.
120+
// // - We must use `bash` here instead of `sh` since `source` isn't available when symlinked to `dash`.
121+
// // - We have to pass the environment variables because `--scope` only inherits the system and not the user environment variables.
122+
// cmd_builder.arg("--slice=codspeed.slice");
123+
// cmd_builder.arg("--scope");
124+
// cmd_builder.arg("--same-dir");
125+
// cmd_builder.arg(format!("--uid={}", nix::unistd::Uid::current().as_raw()));
126+
// cmd_builder.arg(format!("--gid={}", nix::unistd::Gid::current().as_raw()));
127+
// cmd_builder.args(["--"]);
128+
129+
// bench_cmd.wrap_with(cmd_builder);
130130

131131
Ok((env_file, script_file, bench_cmd))
132132
}

src/system/check.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ pub fn check_system(system_info: &SystemInfo) -> Result<()> {
3838
}
3939

4040
match system_info.arch.as_str() {
41-
"x86_64" | "aarch64" => {
41+
"x86_64" | "aarch64" | "arm64" => {
4242
warn!(
4343
"Unofficially supported system: {} {}. Continuing with best effort support.",
4444
system_info.os, system_info.os_version

0 commit comments

Comments
 (0)