A 404 from raise event is inaccurately described as instance not found

[waltervos]

The python implementation has a hardcoded error message for a 404 on context.raise_event(...) that says that the instance ID could not be found. Today I noticed however that I'm getting the same error message when using an event name that contains (presumably) illegal characters. My guess is that the python implementation constructs an invalid URL when the event name contains characters such as slashes and/or asterixes and therefore the API returns a 404. The resulting error message is very confusing though.

From looking through the DurableOrchestrationClient code, no sanitizing of input is being performed. That looks to me like a good place to fix this issue, because why wouldn't an event name with special characters be permitted? The HTTP API docs say nothing about what is and isn't a valid event name.

---

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

• ID: cf8501a6-e09a-0054-36dc-9d958d1b56aa
• Version Independent ID: 534b19ae-7621-de54-d615-77af7fa16f36
• Content: azure.durable_functions.DurableOrchestrationClient class
• Content Source: docs-ref-autogen/azure-functions-durable/azure.durable_functions.DurableOrchestrationClient.yml
• GitHub Login: @lmazuel
• Microsoft Alias: lmazuel

[waltervos]

After thinking it over a little, I guess there are two seperate issues:

1. DurableOrchestrationClient.raise_event() is a bit naive in the way that it handles HTTP errors. A 404 obviously has more error cases than just "No instance with ID {instance_id} found." It would be better if such methods used the actual HTTP reason phrase (which is available from aiohttp)
2. Where allowed, functions preparing URLs should quote URL parts. One example being DurableOrchestrationClient._get_raise_event_url()

[github-actions]

Thank you for your feedback. This has been routed to the support team for assistance.